Skip to content

Conversation

GuillaumeGomez
Copy link
Member

I updated the browser-ui-test version because I fixed GuillaumeGomez/browser-UI-test#507. If inside a function, the colors were not considered, preventing the second commit of this PR.

Follow-up of #111459.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 22, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2023

📌 Commit 194960b has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2023
Rollup of 6 pull requests

Successful merges:

 - rust-lang#111501 (MIR drive-by cleanups)
 - rust-lang#111609 (Mark internal functions and traits unsafe to reflect preconditions)
 - rust-lang#111612 (Give better error when collecting into `&[T]`)
 - rust-lang#111756 (Rename `{drop,forget}_{copy,ref}` lints to more consistent naming)
 - rust-lang#111843 (move lcnr to only review types stuff)
 - rust-lang#111844 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec372a1 into rust-lang:master May 22, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 22, 2023
@GuillaumeGomez GuillaumeGomez deleted the migrate-gui-test-color-4 branch May 23, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS parser doesn't handle colors in functions
4 participants